PHUIDataKit - Bar Chart
AbandonedPublic
Actions

Authored by chad on Feb 9 2015, 8:02 AM.

Details

Reviewers

epriestley
btrahan

Summary

Starting work on PHUIDataKit, an assortment of mini data widgets for various use.

Test Plan

UIExamples.

Diff Detail

Repository

rP Phabricator

Branch

phui-datakit

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4396
Build 4409: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28201.Feb 9 2015, 8:02 AM

chad retitled this revision from to PHUIDataKit - Bar Chart.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 9 2015, 8:02 AM

chad edited the test plan for this revision. (Show Details)Feb 9 2015, 8:02 AM

update spacing

chad mentioned this in T7229: Create comments in diff views is not possible.Feb 10 2015, 6:27 PM

rebase

I want to pursue charts (including bar charts) in JS (specifically, D3) instead. In particular, it is difficult to render line charts in HTML, and server-based charting is generally less flexible than client-side charting. I think all our charting should go through the same foundation so, e.g., a time-window control can be reused on a bar chart vs a line chart without having to have weird special casing for one being client-side and one being server-side.

I don't mind trying to figure out DataKit with D3.js. I just thought a few 'widgets' might be immediately handy. If it isn't, I'm fine holding this until we have D3.

chad abandoned this revision.Mar 1 2015, 3:18 AM