Page MenuHomePhabricator

Make the "daemons and web have different config" warning more specific
ClosedPublic

Authored by epriestley on Feb 5 2015, 9:02 PM.
Tags
None
Referenced Files
F14347815: D11699.diff
Thu, Dec 19, 3:22 AM
Unknown Object (File)
Sun, Dec 15, 6:11 AM
Unknown Object (File)
Sun, Dec 15, 3:53 AM
Unknown Object (File)
Thu, Dec 12, 10:42 AM
Unknown Object (File)
Thu, Dec 12, 6:15 AM
Unknown Object (File)
Sat, Dec 7, 4:52 AM
Unknown Object (File)
Fri, Dec 6, 4:48 AM
Unknown Object (File)
Tue, Dec 3, 6:16 PM
Subscribers

Details

Summary

I'm hitting this in the cluster and couldn't figure it out after staring at it for a couple minutes. Produce a better error.

This dumps a hash of each configuration key value which is set to a non-default value into the daemon log. This is much more compact than the full config, and doesn't spread secrets around, so it seems like a good balance between providing information and going crazy with it.

Test Plan

Screen_Shot_2015-02-05_at_1.00.06_PM.png (1×1 px, 357 KB)

Diff Detail

Repository
rP Phabricator
Branch
envdiff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4363
Build 4376: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make the "daemons and web have different config" warning more specific.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2015, 9:57 PM
This revision was automatically updated to reflect the committed changes.

Here was the culprit:

The configuration key "phabricator.env" is set in both configurations, but set to different values.

(In fairness to my sleuthing skills, we don't set that one in SiteConfig.)