Page MenuHomePhabricator
Differential D11678

Major, increase background color in blockquote
ClosedPublic
Actions

Authored by chad on Feb 4 2015, 5:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 9:04 AM
Unknown Object (File)
Tue, Dec 3, 3:46 AM
Unknown Object (File)
Sat, Nov 30, 2:30 PM
Unknown Object (File)
Wed, Nov 20, 10:37 AM
Unknown Object (File)
Nov 15 2024, 10:57 PM
Unknown Object (File)
Nov 12 2024, 1:10 AM
Unknown Object (File)
Nov 8 2024, 7:56 AM
Unknown Object (File)
Oct 24 2024, 7:55 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP9b28724210db: Major, increase background color in blockquote
Summary

Makes quotes easier to parse visually. Major change.

Test Plan

Quote some text.

Screen_Shot_2015-02-04_at_9.53.24_AM.png (238×546 px, 32 KB)

Screen_Shot_2015-02-04_at_9.55.00_AM.png (164×548 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
blockquote-css
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4324
Build 4337: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28098.Feb 4 2015, 5:54 PM
chad retitled this revision from to Major, increase background color in blockquote.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 4 2015, 5:54 PM
chad edited the test plan for this revision. (Show Details)Feb 4 2015, 5:55 PM
epriestley accepted this revision.Feb 4 2015, 5:56 PM
epriestley edited edge metadata.

This still has a >4.5:1 contrast ratio so it should not constitute a regression of T6792.

This revision is now accepted and ready to land.Feb 4 2015, 5:56 PM
btrahan awarded a token.Feb 4 2015, 5:57 PM
Closed by commit rP9b28724210db: Major, increase background color in blockquote (authored by chad, committed by chad). · Explain WhyFeb 4 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
2 lines

Diff 28098

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility