Paths

Table of Contentst

Differential D11669

Use %B for Harbormaster build log updates as well
ClosedPublic
Actions

Authored by hach-que on Feb 3 2015, 10:50 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP32488687e74d: Use %B for Harbormaster build log updates as well

Summary

So I derped and missed the %s inside the UPDATE query (previously only fixing the INSERT query). This changes %s to %B for the update logic as well.

Test Plan

Patched it in production and saw the offending build run all the way through without UTF8-related exceptions.

Diff Detail

Repository

rP Phabricator

Branch

harbormaster-update

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4309
Build 4322: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 28081.Feb 3 2015, 10:50 PM

hach-que retitled this revision from to Use %B for Harbormaster build log updates as well.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 10:50 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Feb 3 2015, 10:52 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 10:52 PM

Closed by commit rP32488687e74d: Use %B for Harbormaster build log updates as well (authored by hach-que, committed by hach-que). · Explain WhyFeb 3 2015, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildLog.php

2 lines

Diff 28081

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Use %B for Harbormaster build log updates as wellClosedPublicActions