Minor spring cleaning, improve the visual feel of the comments table, more consistent structure.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rPcdd8dcbf17bb: Update InlineCommentSummary UI
Test multiple comments, long comments, short comments, and multiple lines.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- inline-summary-table
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4306 Build 4319: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
At first glance, I don't love this. It feels really busy ("boxes in boxes in boxes") to me.
Removing the left, right, and bottom margins might improve it, so the edges of the table merge into the edges of the comment box? They seem superfluous to me.
The not-full-width one looks kind of arbitrary too. I'd imagine that the varied 66.6%-100% widths might increase the business of multiple consecutive comments by making the right margin ragged. Maybe it would look better as always-full-width?
We also have a similar UI in Pholio, does the table/box treatment make sense there? I'd imagine it might be even worse there, since we have more boxes in the comments (the thumbnail boxes).
Comment Actions
At first glance, I don't love this. It feels really busy ("boxes in boxes in boxes") to me.
I'd have to agree; this might look better if the inline comment box was attached to the bottom of the main comment section rather than inside it?
Comment Actions
Woah, this iteration looks dramatically better to me. Let's see how it works in practice.