Page MenuHomePhabricator
Differential D11665

Arcanist / Conduit - stop using deprecated differential.getdiff API
ClosedPublic
Actions

Authored by btrahan on Feb 3 2015, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 8:01 AM
Unknown Object (File)
Sat, Dec 28, 6:23 PM
Unknown Object (File)
Thu, Dec 12, 4:28 AM
Unknown Object (File)
Mon, Dec 9, 4:56 PM
Unknown Object (File)
Sun, Dec 8, 5:58 AM
Unknown Object (File)
Dec 4 2024, 11:35 AM
Unknown Object (File)
Nov 30 2024, 2:38 AM
Unknown Object (File)
Nov 26 2024, 1:55 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7112: Remove deprecated "differential.getdiff" calls from arcanist
Commits
rARCd98c1049910d: Arcanist / Conduit - stop using deprecated differential.getdiff API
Summary

Fixes T7112. Nothing too difficult here.

Test Plan

meta - submitting this with the new arcanist code
used conduit API to verify the difference between getdiff (just the latest diff) and querydiffs (all diffs that match, with the latest diff first in the set)

Diff Detail

Repository
rARC Arcanist
Branch
T7112
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4305
Build 4318: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28075.Feb 3 2015, 10:02 PM
btrahan added a task: T7112: Remove deprecated "differential.getdiff" calls from arcanist.
btrahan retitled this revision from to Arcanist / Conduit - stop using deprecated differential.getdiff API.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 10:02 PM
btrahan edited the test plan for this revision. (Show Details)Feb 3 2015, 10:04 PM
epriestley accepted this revision.Feb 3 2015, 10:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 10:06 PM
Closed by commit rARCd98c1049910d: Arcanist / Conduit - stop using deprecated differential.getdiff API (authored by btrahan, committed by btrahan). · Explain WhyFeb 3 2015, 10:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28075

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistFeatureWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility