Page MenuHomePhabricator
Differential D11651

Have DifferentialRevisionList return an ObjectBox if header is set
ClosedPublic
Actions

Authored by chad on Feb 3 2015, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 1:54 PM
Unknown Object (File)
Tue, Nov 26, 6:05 AM
Unknown Object (File)
Sat, Nov 23, 1:11 PM
Unknown Object (File)
Tue, Nov 19, 10:34 AM
Unknown Object (File)
Thu, Nov 14, 8:25 PM
Unknown Object (File)
Mon, Nov 11, 6:02 AM
Unknown Object (File)
Fri, Nov 8, 10:27 AM
Unknown Object (File)
Wed, Nov 6, 5:38 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP468985c8275e: Have DifferentialRevisionList return an ObjectBox if header is set
Summary

Moving towards a consisent 'if header, show in object box' style around Phabricator.

Test Plan

Grep for uses of RevisionList and make sure double boxes arent set, browse Differential, various searches, a revision, and a commit.

Screen_Shot_2015-02-03_at_10.23.53_AM.png (1×2 px, 443 KB)

Screen_Shot_2015-02-03_at_10.26.21_AM.png (1×2 px, 442 KB)

Diff Detail

Repository
rP Phabricator
Branch
open-revisions
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4286
Build 4299: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28038.Feb 3 2015, 6:26 PM
chad retitled this revision from to Have DifferentialRevisionList return an Object if header is set.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 6:26 PM
chad edited the test plan for this revision. (Show Details)Feb 3 2015, 6:26 PM
chad retitled this revision from Have DifferentialRevisionList return an Object if header is set to Have DifferentialRevisionList return an ObjectBox if header is set.Feb 3 2015, 6:52 PM
btrahan edited edge metadata.Feb 3 2015, 7:39 PM

I wish the no revisions box was wider so the text all stayed vertically aligned.

epriestley accepted this revision.Feb 3 2015, 7:45 PM
epriestley edited edge metadata.

@btrahan, are you looking at the before/after in the wrong order maybe? The bad alignment is on the "before", I think.

This revision is now accepted and ready to land.Feb 3 2015, 7:45 PM
btrahan added a comment.Feb 3 2015, 7:48 PM

LOL yeah...

Closed by commit rP468985c8275e: Have DifferentialRevisionList return an ObjectBox if header is set (authored by chad, committed by chad). · Explain WhyFeb 3 2015, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
differential/
controller/
5 lines
view/
9 lines
diffusion/
controller/
5 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 28038

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility