Page MenuHomePhabricator
Differential D11638

Add smarter UI for form errors
ClosedPublic
Actions

Authored by chad on Feb 3 2015, 5:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 8:20 AM
Unknown Object (File)
Fri, Jan 24, 7:46 AM
Unknown Object (File)
Thu, Jan 23, 11:24 PM
Unknown Object (File)
Thu, Jan 23, 11:24 PM
Unknown Object (File)
Thu, Jan 23, 11:24 PM
Unknown Object (File)
Thu, Jan 23, 11:24 PM
Unknown Object (File)
Wed, Jan 22, 12:48 PM
Unknown Object (File)
Tue, Jan 21, 11:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP70cddaae3210: Add smarter UI for form errors
Summary

Just makes the UI cleaner on full width or dialog forms (and mobile)

Test Plan

run into a bunch of errors, test mobile breakpoints.

Screen_Shot_2015-02-02_at_9.26.30_PM.png (650×1 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Branch
form-layout-css
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4267
Build 4280: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28010.Feb 3 2015, 5:31 AM
chad retitled this revision from to Add smarter UI for form errors.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 5:31 AM
chad edited the test plan for this revision. (Show Details)Feb 3 2015, 5:31 AM
epriestley accepted this revision.Feb 3 2015, 1:10 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 1:10 PM
Closed by commit rP70cddaae3210: Add smarter UI for form errors (authored by chad, committed by chad). · Explain WhyFeb 3 2015, 3:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
form/
control/
35 lines
webroot/
rsrc/
css/
phui/
15 lines

Diff 28010

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
Phabricator · Built by Phacility