Page MenuHomePhabricator
Differential D11636

Fix printing with new scroll
ClosedPublic
Actions

Authored by chad on Feb 3 2015, 2:34 AM.
Tags
None
Referenced Files
F14060912: D11636.diff
Mon, Nov 18, 4:11 AM
F14048929: D11636.diff
Thu, Nov 14, 10:20 AM
F14040083: D11636.id28008.diff
Mon, Nov 11, 7:21 AM
F14036541: D11636.diff
Sun, Nov 10, 10:41 AM
F14021722: D11636.diff
Wed, Nov 6, 11:43 AM
F14016320: D11636.id28008.diff
Mon, Nov 4, 7:52 AM
F14006276: D11636.id.diff
Mon, Oct 28, 4:47 AM
F13987173: D11636.diff
Mon, Oct 21, 7:54 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T7115: Unable to print any page
Commits
Restricted Diffusion Commit
rP9df4cb37d405: Fix printing with new scroll
Summary

Fixes T7115, at least for me. Unclear if this is the "correct" fix.

Test Plan

Try to print, get page.

Diff Detail

Repository
rP Phabricator
Branch
print-css
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4265
Build 4278: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28005.Feb 3 2015, 2:34 AM
chad retitled this revision from to Fix printing with new scroll.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T7115: Unable to print any page.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 2:34 AM
chad updated this revision to Diff 28006.Feb 3 2015, 2:37 AM
  • Slightly better?
epriestley requested changes to this revision.Feb 3 2015, 2:39 AM
epriestley edited edge metadata.

Use !print on these rules instead of @media print, so ?__print__=1 also activates these rules.

https://secure.phabricator.com/book/phabcontrib/article/css_coding_standards/#printable-rules

e.g.

!print .main-page-frame {
  ...
}
This revision now requires changes to proceed.Feb 3 2015, 2:39 AM
epriestley added a comment.Feb 3 2015, 2:40 AM

(I do think this is the correct fix, at least more or less.)

chad added a comment.Feb 3 2015, 2:41 AM

Oh let me try again, I mucked with printable at first, but couldn't find the magic sauce.

chad updated this revision to Diff 28007.Feb 3 2015, 2:44 AM
chad edited edge metadata.
  • !print
epriestley accepted this revision.Feb 3 2015, 2:44 AM
epriestley edited edge metadata.

Cool, thanks for fixing this!

This revision is now accepted and ready to land.Feb 3 2015, 2:44 AM
epriestley awarded a token.Feb 3 2015, 2:44 AM
Closed by commit rP9df4cb37d405: Fix printing with new scroll (authored by chad, committed by chad). · Explain WhyFeb 3 2015, 2:45 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Feb 3 2015, 2:49 AM

I'm just here so I won't get fined.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
application/
base/
12 lines

Diff 28007

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Phabricator · Built by Phacility