Differential D11635

Probably fix excessive "(authored by X)" attributions
ClosedPublic
Actions

Authored by epriestley on Feb 2 2015, 10:53 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPf1b238cb42e9: Probably fix excessive "(authored by X)" attributions

Summary

This is a pain to test, but we do a lot of needless "X committed thing (authored by X)" right now.

I think that's because we compare two handle links here, and they're never the same, even if they're both links to the same object.

Instead, compare the author and committer more carefully.

Test Plan

Will do it live.

Diff Detail

Repository

rP Phabricator

Branch

authoredby

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4262
Build 4275: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28001.Feb 2 2015, 10:53 PM

epriestley retitled this revision from to Probably fix excessive "(authored by X)" attributions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 2 2015, 10:53 PM

btrahan accepted this revision.Feb 2 2015, 10:57 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2015, 10:57 PM

Closed by commit rPf1b238cb42e9: Probably fix excessive "(authored by X)" attributions (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2015, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Seems like this worked, I haven't seen these these needless attributions since this pushed.

Boomshakalaka!

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialTransaction.php

15 lines

Diff 28001

View Options

src/applications/differential/storage/DifferentialTransaction.php

Probably fix excessive "(authored by X)" attributionsClosedPublicActions