Differential D11581

Policy - clean up the deprecated diffusion.getcommits
ClosedPublic
Actions

Authored by btrahan on Jan 30 2015, 7:46 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7094: Clean up T603

Commits

Restricted Diffusion Commit
rPbdb3adeee485: Policy - clean up the deprecated diffusion.getcommits

Summary

Ref T7094. Could just delete this end point too I guess? Needed to add "withCommitPHIDs" to the differentialrevisionquery to get this done.

Test Plan

used diffusion.getcommits from conduit console and got a sensible result for a query for two commits, one with a diff and one without.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27870.Jan 30 2015, 7:46 PM

btrahan added a task: T7094: Clean up T603.

btrahan retitled this revision from to Policy - clean up the deprecated diffusion.getcommits.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 30 2015, 7:46 PM

I think this approach is desirable in the long run, since this capability is likely useful elsewhere even once we eventually nuke this method.

This revision is now accepted and ready to land.Jan 30 2015, 7:50 PM

Closed by commit rPbdb3adeee485: Policy - clean up the deprecated diffusion.getcommits (authored by btrahan, committed by btrahan). · Explain WhyJan 30 2015, 7:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionQuery.php

29 lines

diffusion/

conduit/

DiffusionGetCommitsConduitAPIMethod.php

46 lines

Diff 27871

View Options

src/applications/differential/query/DifferentialRevisionQuery.php