Page MenuHomePhabricator

Policy - clean up the deprecated diffusion.getcommits
ClosedPublic

Authored by btrahan on Jan 30 2015, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 12:22 PM
Unknown Object (File)
Thu, Nov 28, 8:43 AM
Unknown Object (File)
Tue, Nov 26, 10:51 PM
Unknown Object (File)
Tue, Nov 26, 10:51 PM
Unknown Object (File)
Tue, Nov 26, 10:50 PM
Unknown Object (File)
Tue, Nov 26, 10:32 PM
Unknown Object (File)
Tue, Nov 26, 11:25 AM
Unknown Object (File)
Nov 20 2024, 3:20 PM
Subscribers

Details

Summary

Ref T7094. Could just delete this end point too I guess? Needed to add "withCommitPHIDs" to the differentialrevisionquery to get this done.

Test Plan

used diffusion.getcommits from conduit console and got a sensible result for a query for two commits, one with a diff and one without.

Diff Detail

Repository
rP Phabricator
Branch
T7094_2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4188
Build 4201: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Policy - clean up the deprecated diffusion.getcommits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

I think this approach is desirable in the long run, since this capability is likely useful elsewhere even once we eventually nuke this method.

This revision is now accepted and ready to land.Jan 30 2015, 7:50 PM
This revision was automatically updated to reflect the committed changes.