Kind of generate a bill for users
ClosedPublic
Actions

Authored by epriestley on Jan 30 2015, 7:33 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune

Commits

Restricted Diffusion Commit
rPd1e793a292a1: Kind of generate a bill for users

Summary

Ref T6881. This generates a product, purchase and invoice for users, and there's sort of some UI for them. Stuff it doesn't do yet:

Try to autobill when we have a CC;
actually tell the user they should pay it;
ask the application for anything like "how much should we charge", or tell the application anything like "the user paid".

However, these work:

You can technically pay the invoices.
You can see the invoices you paid in the past.

Test Plan

Used bin/phriction invoice to double-bill myself over and over again. Paid one of the invoices.

Diff Detail

Repository

rP Phabricator

Branch

sub4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/phortune/product/PhortuneSubscriptionProduct.php:52	XHP16	TODO Comment
Advice	src/applications/phortune/product/PhortuneSubscriptionProduct.php:60	XHP16	TODO Comment
Advice	src/applications/phortune/worker/PhortuneSubscriptionWorker.php:25	XHP16	TODO Comment
Advice	src/applications/phortune/worker/PhortuneSubscriptionWorker.php:45	XHP16	TODO Comment
Advice	src/applications/phortune/worker/PhortuneSubscriptionWorker.php:57	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 4187
Build 4200: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27869.Jan 30 2015, 7:33 PM

epriestley retitled this revision from to Kind of generate a bill for users.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 30 2015, 7:33 PM

Screen_Shot_2015-01-30_at_11.32.59_AM.png (1×1 px, 159 KB)

One architecture note here: we don't technically need the subscriptionPHID on the cart, since we could find carts which contain a Purchase of the Product which is uniquely associated with the Subscription.

However, it's way cleaner/easier to just let Carts know about Subscriptions, and Subscriptions are a "native" object to Phortune, and some other UI is going to need to know about them anyway, so I don't think there's any real downside to this.

In general, Subscriptions are just normal purchases which are made for you every month, except that you provide a SubscriptionImplementation instead of a ProductImplementation + CartImplementaiton, and Phortune automatically builds a reasonable Product + Cart for you since they aren't very interesting in this case.

chad awarded a token.Jan 30 2015, 7:41 PM