Differential D11524

Give Maniphest a title glyph
ClosedPublic
Actions

Authored by epriestley on Jan 27 2015, 3:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 29, 3:21 AM

	Unknown Object (File)
	Fri, Dec 20, 11:30 PM

	Unknown Object (File)
	Tue, Dec 17, 9:50 AM

	Unknown Object (File)
	Tue, Dec 17, 2:44 AM

	Unknown Object (File)
	Sat, Dec 14, 3:42 PM

	Unknown Object (File)
	Thu, Dec 5, 4:04 AM

	Unknown Object (File)
	Tue, Dec 3, 4:34 PM

	Unknown Object (File)
	Nov 28 2024, 5:20 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7055: ApplicationSearch page titles have slightly too little context after removing "Query:"?

Commits

Restricted Diffusion Commit
rP5b6b2ee8505f: Give Maniphest a title glyph

Summary

Ref T7055. Apparently we just never had one? I feel like I'm crazy. But I can't find any trace in the logs.

I'm actually not 100% sold on this being better because it's a color glyph on OSX and those feel a little out of place / tacky to me compared to the black-and-white ones. So I'd be fine with just leaving it off, too. Clearly not important if no one noticed it until I caught it in T7055.

Test Plan

Screen_Shot_2015-01-27_at_7.45.41_AM.png (33×120 px, 6 KB)

Diff Detail

Repository

Branch

glyph1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4087
Build 4100: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27712.Jan 27 2015, 3:46 PM

epriestley retitled this revision from to Give Maniphest a title glyph.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7055: ApplicationSearch page titles have slightly too little context after removing "Query:"?.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 27 2015, 3:46 PM

chad accepted this revision.Jan 27 2015, 4:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2015, 4:25 PM

Closed by commit rP5b6b2ee8505f: Give Maniphest a title glyph (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2015, 10:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

application/

PhabricatorManiphestApplication.php

4 lines

Diff 27712

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...