Page MenuHomePhabricator
Differential D11523

Fix inline reticles and dialogs for new scrollbars
ClosedPublic
Actions

Authored by epriestley on Jan 27 2015, 2:59 PM.
Tags
None
Referenced Files
F14066469: D11523.diff
Tue, Nov 19, 9:59 AM
F14001449: D11523.diff
Fri, Oct 25, 8:08 AM
F13973359: D11523.diff
Oct 18 2024, 12:35 AM
F13967077: D11523.id27711.diff
Oct 16 2024, 11:31 AM
Unknown Object (File)
Oct 13 2024, 8:23 PM
Unknown Object (File)
Oct 7 2024, 10:30 PM
Unknown Object (File)
Oct 2 2024, 6:24 PM
Unknown Object (File)
Oct 2 2024, 4:21 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7049: Dialogs always move page back to top
T7054: Scrolling page after highlighting inlines scrolls the reticle, too
Commits
Restricted Diffusion Commit
rP41dcd7420b5b: Fix inline reticles and dialogs for new scrollbars
Summary

Fixes T7054. Fixes T7049.

  • Stop scrolling Differential reticles when the page scrolls.
  • Make dialogs aware of multi-panel UI.
Test Plan
  • Dialogs pop up in the right place.
  • Inline + scroll now longer leaves the inline in a fixed position.

Diff Detail

Repository
rP Phabricator
Branch
scrollx1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4086
Build 4099: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27710.Jan 27 2015, 2:59 PM
epriestley retitled this revision from to Fix inline reticles and dialogs for new scrollbars.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added tasks: T7054: Scrolling page after highlighting inlines scrolls the reticle, too, T7049: Dialogs always move page back to top.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 27 2015, 2:59 PM
chad accepted this revision.Jan 27 2015, 3:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2015, 3:03 PM
Closed by commit rP41dcd7420b5b: Fix inline reticles and dialogs for new scrollbars (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2015, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
50 lines
webroot/
rsrc/
externals/
javelin/
lib/
8 lines
js/
application/
differential/
14 lines

Diff 27710

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Workflow.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Loading...
Phabricator · Built by Phacility