Approximately rough in persistent chat column very roughly
ClosedPublic
Actions

Authored by epriestley on Jan 25 2015, 10:25 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rP893243b7897b: Approximately rough in persistent chat column very roughly

Summary

Ref T7014. This is very rough and not hooked up to anything, but gets a couple of the layout pieces in place so we can (a) see that it looks like it'll kinda work; (b) look for problematic interactions and (c) you can fix my mangling of your design.

NOTE: Press "\" to toggle the column.

Test Plan

Feels pretty good to me?

Screen_Shot_2015-01-25_at_2.23.47_PM.png (1×1 px, 422 KB)

Diff Detail

Repository

rP Phabricator

Branch

durable1

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/conpherence/behavior-durable-column.js:1	JAVELIN5	`javelinsymbols` Not In Path
Advice	src/view/phui/PHUIDurableColumn.php:37	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 4068
Build 4081: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27652.Jan 25 2015, 10:25 PM

epriestley retitled this revision from to Approximately rough in persistent chat column very roughly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7014: Annouce Persistent Chat option in Conpherence.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 25 2015, 10:25 PM

Header text style is definitely wrong but I don't think I missed the mark by too much elsewhere.

(I mean, I'm sure all the paddings are wrong or whatever.)

From browsing around:

Obviously bad on Conpherence, we'll just disable it there.
Seems fine on workboards.
Seems fine on all other pages I've looked at (on a wide monitor, at least).
Scrollbars and scrolling behavior feels pretty good, although I might want to make it so only one scrollbar is visible at a time. When you wave your mouse over the document and activate both of them they draw the eye a little much, to me? Might just need to get used to it.

This layout makes an interesting argument for a fixed header.

Do you want to make a branch for this, or we just doing it live (hidden)?

Let me de-hack this a little bit but I think we can just dump it into master as long as it's somewhat-hidden-ish.

epriestley mentioned this in D11507: Quicksand, an ignoble successor to Quickling.Jan 26 2015, 4:39 PM

Underp the copy enough that users won't be confused if they activate this by accident.
Because this enables D11507 and that's likely going to need to bake for a while, I think it's reasonable to land it in a pretty rough state.