Page MenuHomePhabricator
Differential D11496

Remove 1x AppIcons, use FontIcons instead
ClosedPublic
Actions

Authored by chad on Jan 25 2015, 9:53 PM.
Tags
None
Referenced Files
F14534403: D11496.diff
Mon, Jan 6, 10:54 PM
Unknown Object (File)
Sat, Dec 14, 1:20 AM
Unknown Object (File)
Mon, Dec 9, 5:51 AM
Unknown Object (File)
Nov 27 2024, 12:47 PM
Unknown Object (File)
Nov 23 2024, 2:27 PM
Unknown Object (File)
Nov 19 2024, 10:50 AM
Unknown Object (File)
Nov 15 2024, 9:32 AM
Unknown Object (File)
Nov 11 2024, 2:00 AM
View All Files
Subscribers
epriestley
hach-que
Korvin
Tokens
"Love" token, awarded by johnny-bit.

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP6018ef91b8b8: Remove 1x AppIcons, use FontIcons instead
Summary

Removes the 1x application icons, and uses the fonticons instead. Feed was only known location.

Test Plan

feed, dashboards, grep for use

pasted_file (519×223 px, 61 KB)

Diff Detail

Repository
rP Phabricator
Branch
feed-icons
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4041
Build 4054: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27649.Jan 25 2015, 9:53 PM
chad retitled this revision from to Remove 1x AppIcons, use FontIcons instead.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald TranscriptJan 25 2015, 9:53 PM
chad edited the test plan for this revision. (Show Details)Jan 25 2015, 9:54 PM
epriestley accepted this revision.Jan 25 2015, 9:55 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
77

(Extra space after -> here.)

This revision is now accepted and ready to land.Jan 25 2015, 9:55 PM
chad updated this revision to Diff 27650.Jan 25 2015, 10:10 PM
chad edited edge metadata.
  • fix spacing
  • Remove old icon calls
Closed by commit rP6018ef91b8b8: Remove 1x AppIcons, use FontIcons instead (authored by chad, committed by chad). · Explain WhyJan 25 2015, 10:14 PM
This revision was automatically updated to reflect the committed changes.
johnny-bit awarded a token.Jan 26 2015, 12:04 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
1 line
sprite/
apps_dark_1x/
manifest/
scripts/
celerity/
1 line
src/
applications/
celerity/
5 lines
diffusion/
application/
2 lines
feed/
story/
1 line
1 line
1 line
1 line
1 line
1 line
phame/
controller/
2 lines
tokens/
feed/
1 line
transactions/
feed/
14 lines
uiexample/
examples/
12 lines
view/
phui/
24 lines
1 line
8 lines
webroot/
rsrc/
css/
phui/
2 lines
image/

Diff 27650

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

resources/sprite/apps_dark_1x/adventure.png

Loading...
View Options

resources/sprite/apps_dark_1x/aphlict.png

Loading...
View Options

resources/sprite/apps_dark_1x/application.png

Loading...
View Options

resources/sprite/apps_dark_1x/audit.png

Loading...
View Options

resources/sprite/apps_dark_1x/authentication.png

Loading...
View Options

resources/sprite/apps_dark_1x/calendar.png

Loading...
View Options

resources/sprite/apps_dark_1x/chatlog.png

Loading...
View Options

resources/sprite/apps_dark_1x/conduit.png

Loading...
View Options

resources/sprite/apps_dark_1x/conpherence.png

Loading...
View Options

resources/sprite/apps_dark_1x/countdown.png

Loading...
View Options

resources/sprite/apps_dark_1x/daemon.png

Loading...
View Options

resources/sprite/apps_dark_1x/differential.png

Loading...
View Options

resources/sprite/apps_dark_1x/diffusion.png

Loading...
View Options

resources/sprite/apps_dark_1x/diviner.png

Loading...
View Options

resources/sprite/apps_dark_1x/drydock.png

Loading...
View Options

resources/sprite/apps_dark_1x/fact.png

Loading...
View Options

resources/sprite/apps_dark_1x/fancyhome.png

Loading...
View Options

resources/sprite/apps_dark_1x/feed.png

Loading...
View Options

resources/sprite/apps_dark_1x/files.png

Loading...
View Options

resources/sprite/apps_dark_1x/flags.png

Loading...
View Options

resources/sprite/apps_dark_1x/harbormaster.png

Loading...
View Options

resources/sprite/apps_dark_1x/help.png

Loading...
View Options

resources/sprite/apps_dark_1x/herald.png

Loading...
View Options

resources/sprite/apps_dark_1x/home.png

Loading...
View Options

resources/sprite/apps_dark_1x/info-sm.png

Loading...
View Options

resources/sprite/apps_dark_1x/legalpad.png

Loading...
View Options

resources/sprite/apps_dark_1x/logo.png

Loading...
View Options

resources/sprite/apps_dark_1x/logout-sm.png

Loading...
View Options

resources/sprite/apps_dark_1x/macro.png

Loading...
View Options

resources/sprite/apps_dark_1x/mail.png

Loading...
View Options

resources/sprite/apps_dark_1x/maniphest.png

Loading...
View Options

resources/sprite/apps_dark_1x/metamta.png

Loading...
View Options

resources/sprite/apps_dark_1x/new-sm.png

Loading...
View Options

resources/sprite/apps_dark_1x/new.png

Loading...
View Options

resources/sprite/apps_dark_1x/nuance.png

Loading...
View Options

resources/sprite/apps_dark_1x/owners.png

Loading...
View Options

resources/sprite/apps_dark_1x/passphrase.png

Loading...
View Options

resources/sprite/apps_dark_1x/paste.png

Loading...
View Options

resources/sprite/apps_dark_1x/pebkac.png

Loading...
View Options

resources/sprite/apps_dark_1x/people.png

Loading...
View Options

resources/sprite/apps_dark_1x/phage.png

Loading...
View Options

resources/sprite/apps_dark_1x/phame.png

Loading...
View Options

resources/sprite/apps_dark_1x/phid.png

Loading...
View Options

resources/sprite/apps_dark_1x/phlux.png

Loading...
View Options

resources/sprite/apps_dark_1x/pholio.png

Loading...
View Options

resources/sprite/apps_dark_1x/phortune.png

Loading...
View Options

resources/sprite/apps_dark_1x/phpast.png

Loading...
View Options

resources/sprite/apps_dark_1x/phragment.png

Loading...
View Options

resources/sprite/apps_dark_1x/phrequent.png

Loading...
View Options

resources/sprite/apps_dark_1x/phriction.png

Loading...
View Options

resources/sprite/apps_dark_1x/phund.png

Loading...
View Options

resources/sprite/apps_dark_1x/policy.png

Loading...
View Options

resources/sprite/apps_dark_1x/ponder.png

Loading...
View Options

resources/sprite/apps_dark_1x/power.png

Loading...
View Options

resources/sprite/apps_dark_1x/projects.png

Loading...
View Options

resources/sprite/apps_dark_1x/releeph.png

Loading...
View Options

resources/sprite/apps_dark_1x/repositories.png

Loading...
View Options

resources/sprite/apps_dark_1x/search.png

Loading...
View Options

resources/sprite/apps_dark_1x/settings-sm.png

Loading...
View Options

resources/sprite/apps_dark_1x/settings.png

Loading...
View Options

resources/sprite/apps_dark_1x/setup.png

Loading...
View Options

resources/sprite/apps_dark_1x/slowvote.png

Loading...
View Options

resources/sprite/apps_dark_1x/spaces.png

Loading...
View Options

resources/sprite/apps_dark_1x/token.png

Loading...
View Options

resources/sprite/apps_dark_1x/uiexamples.png

Loading...
View Options

resources/sprite/apps_dark_1x/workboard.png

Loading...
View Options

resources/sprite/apps_dark_1x/workphlow.png

Loading...
View Options

resources/sprite/apps_dark_1x/xhprof.png

Loading...
View Options

resources/sprite/manifest/apps.json

Loading...
View Options

scripts/celerity/generate_sprites.php

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryAudit.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryCommit.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryDifferential.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryPhriction.php

Loading...
View Options

src/applications/phame/controller/PhameController.php

Loading...
View Options

src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php

Loading...
View Options

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...
View Options

src/applications/uiexample/examples/PHUIFeedStoryExample.php

Loading...
View Options

src/view/phui/PHUIFeedStoryView.php

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
View Options

src/view/phui/PHUIListItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-feed-story.css

Loading...
View Options

webroot/rsrc/css/sprite-apps.css

Loading...
View Options

webroot/rsrc/image/sprite-apps-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-apps-X4.png

Loading...
View Options

webroot/rsrc/image/sprite-apps.png

Loading...
Phabricator · Built by Phacility