Page MenuHomePhabricator

Fix window-exiting drags and drag-and-hold behaviors in JX.Scrollbar
ClosedPublic

Authored by epriestley on Jan 25 2015, 12:29 AM.
Tags
None
Referenced Files
F15505228: D11487.id27632.diff
Tue, Apr 15, 1:01 AM
F15503736: D11487.id27633.diff
Mon, Apr 14, 12:35 PM
F15502803: D11487.id27634.diff
Mon, Apr 14, 4:27 AM
F15488219: D11487.id.diff
Thu, Apr 10, 8:24 PM
F15488141: D11487.id27633.diff
Thu, Apr 10, 7:49 PM
F15484403: D11487.diff
Wed, Apr 9, 6:07 PM
F15470435: D11487.diff
Fri, Apr 4, 10:09 PM
F15449530: D11487.id.diff
Fri, Mar 28, 10:49 AM
Subscribers
Tokens
"Love" token, awarded by johnny-bit.

Details

Summary

Fixes two issues:

  • In Firefox, dragging outside the window and releasing the mouse button would miss the mouseup event. This would leave the bar dragging, even though the user had released the mouse button.
  • In all browsers, dragging the handle and then holding your cursor in one place for more than a second would hide the handle. Instead, never hide the handle during a drag.
Test Plan
  • In Firefox, dragged handle right (outside of window) and released mouse button. Waved cursor over window; no more "sticky" scroll.
  • In FF/Chrome/Safari, dragged handle and held cursor in same position for several seconds. No more handle hide.
  • Waved cursor over window and made sure normal hiding still works.

Diff Detail

Repository
rP Phabricator
Branch
scrollx4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4029
Build 4042: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix window-exiting drags and drag-and-hold behaviors in JX.Scrollbar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 25 2015, 12:42 AM
This revision was automatically updated to reflect the committed changes.