Page MenuHomePhabricator

Differential - return a better response for validation error cases
ClosedPublic

Authored by btrahan on Jan 20 2015, 9:40 PM.
Tags
None
Referenced Files
F19345586: D11448.id27520.diff
Fri, Dec 26, 1:11 AM
F19315672: D11448.id27521.diff
Thu, Dec 25, 3:50 AM
F18921558: D11448.id.diff
Nov 9 2025, 2:15 PM
F18898451: D11448.diff
Nov 7 2025, 6:36 PM
F18856813: D11448.diff
Nov 1 2025, 11:38 AM
F18856747: D11448.id.diff
Nov 1 2025, 11:20 AM
F18852449: D11448.id27520.diff
Oct 31 2025, 9:10 AM
F18629162: D11448.id27521.diff
Sep 16 2025, 8:07 AM
Subscribers
Tokens
"Grey Medal" token, awarded by epriestley.

Details

Summary

Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan

tried to add myself as a reviewer and got a nice error message.

Diff Detail

Repository
rP Phabricator
Branch
T6989
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3949
Build 3962: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Differential - return a better response for validation error cases.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM
This revision was automatically updated to reflect the committed changes.