Differential D11448

Differential - return a better response for validation error cases
ClosedPublic
Actions

Authored by btrahan on Jan 20 2015, 9:40 PM.

Tags

None

Referenced Files

	F14407509: D11448.diff
	Tue, Dec 24, 3:03 AM

	Unknown Object (File)
	Thu, Dec 12, 6:13 PM

	Unknown Object (File)
	Thu, Dec 12, 10:49 AM

	Unknown Object (File)
	Wed, Dec 4, 10:31 AM

	Unknown Object (File)
	Wed, Nov 27, 8:11 PM

	Unknown Object (File)
	Tue, Nov 26, 1:04 PM

	Unknown Object (File)
	Nov 23 2024, 2:18 PM

	Unknown Object (File)
	Nov 23 2024, 2:18 PM

Subscribers

Tokens

"Grey Medal" token, awarded by epriestley.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6989: Adding yourself as a reviewer explodes in glorious fashion

Commits

Restricted Diffusion Commit
rP847ff549ceee: Differential - return a better response for validation error cases

Summary

Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan

tried to add myself as a reviewer and got a nice error message.

Diff Detail

Repository

Branch

T6989

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3949
Build 3962: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27520.Jan 20 2015, 9:40 PM

btrahan added a task: T6989: Adding yourself as a reviewer explodes in glorious fashion.

btrahan retitled this revision from to Differential - return a better response for validation error cases.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 20 2015, 9:40 PM

Nice!

This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM

epriestley awarded a token.Jan 20 2015, 9:58 PM

Closed by commit rP847ff549ceee: Differential - return a better response for validation error cases (authored by btrahan, committed by btrahan). · Explain WhyJan 20 2015, 9:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

controller/

DifferentialCommentSaveController.php

5 lines

editor/

DifferentialTransactionEditor.php

1 line

transactions/

response/

PhabricatorApplicationTransactionValidationResponse.php

49 lines

Diff 27520

src/__phutil_library_map__.php

Loading...

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/transactions/response/PhabricatorApplicationTransactionValidationResponse.php

Loading...