Page MenuHomePhabricator
Differential D11436

Add order-by-ID to PhabricatorWorkerTriggerQuery
ClosedPublic
Actions

Authored by epriestley on Jan 19 2015, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:25 AM
Unknown Object (File)
Thu, Dec 19, 4:12 AM
Unknown Object (File)
Sat, Dec 7, 5:07 PM
Unknown Object (File)
Tue, Nov 26, 4:33 AM
Unknown Object (File)
Nov 18 2024, 10:40 AM
Unknown Object (File)
Nov 13 2024, 9:34 PM
Unknown Object (File)
Nov 9 2024, 11:29 PM
Unknown Object (File)
Nov 6 2024, 9:56 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune
Commits
Restricted Diffusion Commit
rPef106d297935: Add order-by-ID to PhabricatorWorkerTriggerQuery
Summary

Ref T6881. By design, the EXECUTION order only selects tasks which have been scheduled (since it performs a JOIN). This is inconsistent with other queries and problematic for withID/withPHID queries which may want to select an unscheduled task.

Switch to standard ID ordering by default.

Test Plan
  • Instances console now finds unscheduled triggers.
  • Verified that all existing queries specify an explicit order.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27478.Jan 19 2015, 10:36 PM
epriestley retitled this revision from to Add order-by-ID to PhabricatorWorkerTriggerQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 19 2015, 10:36 PM
btrahan accepted this revision.Jan 19 2015, 10:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 19 2015, 10:38 PM
Closed by commit rPef106d297935: Add order-by-ID to PhabricatorWorkerTriggerQuery (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 12:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
workers/
query/
17 lines

Diff 27487

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...
Phabricator · Built by Phacility