Page MenuHomePhabricator
Differential D11436

Add order-by-ID to PhabricatorWorkerTriggerQuery
ClosedPublic
Actions

Authored by epriestley on Jan 19 2015, 10:36 PM.
Tags
None
Referenced Files
F15432809: D11436.diff
Mon, Mar 24, 7:41 PM
F15424848: D11436.id27478.diff
Sun, Mar 23, 12:27 AM
F15419430: D11436.id27487.diff
Fri, Mar 21, 6:00 AM
F15417120: D11436.id.diff
Thu, Mar 20, 3:30 PM
F15413998: D11436.diff
Wed, Mar 19, 10:23 PM
F15397368: D11436.id27487.diff
Sun, Mar 16, 7:49 PM
F15336434: D11436.id27487.diff
Sat, Mar 8, 6:50 PM
F15310021: D11436.diff
Thu, Mar 6, 7:59 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune
Commits
Restricted Diffusion Commit
rPef106d297935: Add order-by-ID to PhabricatorWorkerTriggerQuery
Summary

Ref T6881. By design, the EXECUTION order only selects tasks which have been scheduled (since it performs a JOIN). This is inconsistent with other queries and problematic for withID/withPHID queries which may want to select an unscheduled task.

Switch to standard ID ordering by default.

Test Plan
  • Instances console now finds unscheduled triggers.
  • Verified that all existing queries specify an explicit order.

Diff Detail

Repository
rP Phabricator
Branch
trigger5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3920
Build 3933: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27478.Jan 19 2015, 10:36 PM
epriestley retitled this revision from to Add order-by-ID to PhabricatorWorkerTriggerQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 19 2015, 10:36 PM
btrahan accepted this revision.Jan 19 2015, 10:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 19 2015, 10:38 PM
Closed by commit rPef106d297935: Add order-by-ID to PhabricatorWorkerTriggerQuery (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 12:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
workers/
query/
17 lines

Diff 27478

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...
Phabricator · Built by Phacility