Fix an issue with Auth edit 404ing
ClosedPublic
Actions

Authored by epriestley on Jan 14 2015, 7:01 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6971: Unhandled Exception ("RuntimeException") – Undefined variable: provider

Commits

Restricted Diffusion Commit
rPbdfbad092b05: Fix an issue with Auth edit 404ing

Summary

Fixes T6971. This parameter got updated slightly wrong.

Test Plan

Edited an auth provider.

Diff Detail

Repository

rP Phabricator

Branch

authedit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3842
Build 3854: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27355.Jan 14 2015, 7:01 PM

epriestley retitled this revision from to Fix an issue with Auth edit 404ing.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T6971: Unhandled Exception ("RuntimeException") – Undefined variable: provider.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 14 2015, 7:01 PM

epriestley added inline comments.Jan 14 2015, 7:02 PM

src/applications/files/controller/PhabricatorFileComposeController.php
51–53	ololol

Shhhh.

btrahan accepted this revision.Jan 14 2015, 7:03 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2015, 7:03 PM

Closed by commit rPbdfbad092b05: Fix an issue with Auth edit 404ing (authored by epriestley, committed by epriestley). · Explain WhyJan 14 2015, 7:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

config/

PhabricatorAuthEditController.php

2 lines

files/

controller/

PhabricatorFileComposeController.php

3 lines

Diff 27355

View Options

src/applications/auth/controller/config/PhabricatorAuthEditController.php