Page MenuHomePhabricator
Differential D11379

Float actions in header for better overflow
ClosedPublic
Actions

Authored by chad on Jan 14 2015, 12:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 8:21 AM
Unknown Object (File)
Wed, Nov 20, 2:29 PM
Unknown Object (File)
Mon, Nov 18, 7:24 AM
Unknown Object (File)
Wed, Nov 13, 8:18 PM
Unknown Object (File)
Sat, Nov 9, 5:11 PM
Unknown Object (File)
Tue, Nov 5, 8:24 PM
Unknown Object (File)
Mon, Nov 4, 8:14 AM
Unknown Object (File)
Oct 23 2024, 2:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6964: Title is cut off by action menu
Commits
Restricted Diffusion Commit
rP2ece93aafe08: Float actions in header for better overflow
Summary

Fixes T6964, makes action links float instead of absolutely positioned.

Test Plan

Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows.

Diff Detail

Repository
rP Phabricator
Branch
mobile-menu-spacing
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3828
Build 3840: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27333.Jan 14 2015, 12:07 AM
chad retitled this revision from to Float actions in header for better overflow.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T6964: Title is cut off by action menu.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 14 2015, 12:07 AM
epriestley accepted this revision.Jan 14 2015, 12:09 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2015, 12:09 AM
Closed by commit rP2ece93aafe08: Float actions in header for better overflow (authored by chad, committed by chad). · Explain WhyJan 14 2015, 12:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
210 lines
src/
view/
phui/
52 lines
webroot/
rsrc/
css/
phui/
14 lines
2 lines

Diff 27333

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
Phabricator · Built by Phacility