Page MenuHomePhabricator
Differential D11373

Followup from D11358#106424 and make policy.locked fully work
ClosedPublic
Actions

Authored by btrahan on Jan 13 2015, 7:55 PM.
Tags
None
Referenced Files
F14474057: D11373.id27313.diff
Fri, Dec 27, 3:18 PM
Unknown Object (File)
Wed, Dec 18, 2:36 AM
Unknown Object (File)
Tue, Dec 17, 1:15 AM
Unknown Object (File)
Fri, Dec 13, 8:27 AM
Unknown Object (File)
Fri, Dec 13, 5:07 AM
Unknown Object (File)
Fri, Dec 13, 2:30 AM
Unknown Object (File)
Thu, Dec 12, 1:16 PM
Unknown Object (File)
Thu, Dec 12, 1:08 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6947: Add configuration to lock auth/user creation, or to lock application policies
Commits
Restricted Diffusion Commit
rP32edb7e2bbe8: Followup from D11358#106424 and make policy.locked fully work
Summary

Fast commit. Also forgot to make the config override the existing policy. I *think* this is the right spot and we're good? Ref T6947.

Test Plan

viewed the application settings page for people application and saw the correct overrode setting.

Diff Detail

Repository
rP Phabricator
Branch
whoops
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3821
Build 3833: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27313.Jan 13 2015, 7:55 PM
btrahan retitled this revision from to Followup from D11358#106424 and make policy.locked fully work.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T6947: Add configuration to lock auth/user creation, or to lock application policies.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 13 2015, 7:55 PM
epriestley accepted this revision.Jan 13 2015, 7:58 PM
epriestley edited edge metadata.

Possibly-better location for the override inline?

src/applications/policy/query/PhabricatorPolicyQuery.php
26–33 ↗(On Diff #27313)

Hmm, I think I'd try putting this in PhabricatorApplication->getCustomPolicySetting() instead.

This revision is now accepted and ready to land.Jan 13 2015, 7:58 PM
btrahan updated this revision to Diff 27316.Jan 13 2015, 8:02 PM
btrahan edited edge metadata.

put the override in the better spot

Closed by commit rP32edb7e2bbe8: Followup from D11358#106424 and make policy.locked fully work (authored by btrahan, committed by btrahan). · Explain WhyJan 13 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
5 lines
meta/
controller/
5 lines
policy/
config/
1 line

Diff 27316

View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationEditController.php

Loading...
View Options

src/applications/policy/config/PhabricatorPolicyConfigOptions.php

Loading...
Phabricator · Built by Phacility