Fix slowvote exception when viewing description diff
ClosedPublic
Actions

Authored by epriestley on Jan 12 2015, 3:19 PM.

Tags

None

Referenced Files

	F13987987: D11346.diff
	Mon, Oct 21, 12:29 PM

	F13986174: D11346.id27252.diff
	Mon, Oct 21, 1:08 AM

	F13986160: D11346.id27251.diff
	Mon, Oct 21, 1:03 AM

	F13986159: D11346.id27251.diff
	Mon, Oct 21, 1:03 AM

	F13986093: D11346.id27252.diff
	Mon, Oct 21, 12:31 AM

	F13985795: D11346.id.diff
	Sun, Oct 20, 10:56 PM

	F13985762: D11346.diff
	Sun, Oct 20, 10:46 PM

	F13985637: D11346.diff
	Sun, Oct 20, 9:57 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6937: RuntimeException thrown when clicking 'show details' in Slowvote

Commits

Restricted Diffusion Commit
rP2189b6df6d88: Fix slowvote exception when viewing description diff

Summary

Fixes T6937. We weren't passing required parameters.

Test Plan

Followed repro steps in task.

Diff Detail

Repository

rP Phabricator

Branch

svstack

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3784
Build 3795: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27251.Jan 12 2015, 3:19 PM

epriestley retitled this revision from to Fix slowvote exception when viewing description diff.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6937: RuntimeException thrown when clicking 'show details' in Slowvote.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 12 2015, 3:19 PM

chad accepted this revision.Jan 12 2015, 3:20 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Jan 12 2015, 3:20 PM

Closed by commit rP2189b6df6d88: Fix slowvote exception when viewing description diff (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2015, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

slowvote/

storage/

PhabricatorSlowvoteTransaction.php

5 lines

Diff 27251

View Options

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

Fix slowvote exception when viewing description diffClosedPublicActions