Page MenuHomePhabricator

Diffusion - return 404 errors for bad URIs
ClosedPublic

Authored by btrahan on Jan 9 2015, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 6 2025, 11:22 AM
Unknown Object (File)
May 6 2025, 1:57 AM
Unknown Object (File)
May 5 2025, 9:30 PM
Unknown Object (File)
Apr 28 2025, 2:33 AM
Unknown Object (File)
Apr 23 2025, 11:33 PM
Unknown Object (File)
Apr 17 2025, 8:38 AM
Unknown Object (File)
Apr 16 2025, 11:54 PM
Unknown Object (File)
Apr 12 2025, 11:17 AM
Subscribers

Details

Summary

Fixes T5646. Makes diffusion a much better user experience. Users now see a 404 exception page when they have a bad URI. Previously, they saw a developer-facing raw exception.

Test Plan

played around in diffusion a bunch. most of these changes were fairly mechanical at the end of the day.

Diff Detail

Repository
rP Phabricator
Branch
T5646
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3717
Build 3728: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Diffusion - return 404 errors for bad URIs.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
src/applications/diffusion/controller/DiffusionChangeController.php
11

i'll tighten this up

src/applications/diffusion/controller/DiffusionCommitBranchesController.php
9–12

this does nothing...

src/applications/diffusion/controller/DiffusionCommitController.php
14–25

this is a problem; will fix

epriestley edited edge metadata.

You caught everything I caught. Looks good modulo your one inline.

This revision is now accepted and ready to land.Jan 9 2015, 9:18 PM
btrahan edited edge metadata.
  • updates
  • also fixed DiffController, where I forgot to initialize $data originally
This revision was automatically updated to reflect the committed changes.