Page MenuHomePhabricator
Differential D11298

OAuthServer - harden things up a bit
ClosedPublic
Actions

Authored by btrahan on Jan 9 2015, 6:57 PM.
Tags
None
Referenced Files
F18749806: D11298.id27146.diff
Sat, Oct 4, 5:12 AM
F18749113: D11298.diff
Sat, Oct 4, 2:24 AM
F18736471: D11298.id.diff
Wed, Oct 1, 6:05 AM
F18712359: D11298.id.diff
Mon, Sep 29, 5:22 AM
F18659550: D11298.id.diff
Tue, Sep 23, 1:19 PM
F18654414: D11298.diff
Mon, Sep 22, 8:40 AM
F18565717: D11298.id.diff
Tue, Sep 9, 1:39 PM
F18496301: D11298.diff
Thu, Sep 4, 5:20 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4593: Mitigate OAuth session theft
Commits
Restricted Diffusion Commit
rP152072fc974b: OAuthServer - harden things up a bit
Summary

This is the hardening work mentioned in T887#86529. Also take a documentation pass for accuracy about these changes and formatting. Ref T4593.

Test Plan

unit tests...! generated diviner docs and oauthserver doc looked good

Diff Detail

Repository
rP Phabricator
Branch
hardenoauth
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3714
Build 3725: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27146.Jan 9 2015, 6:57 PM
btrahan retitled this revision from to OAuthServer - harden things up a bit.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T4593: Mitigate OAuth session theft.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 9 2015, 6:57 PM
epriestley accepted this revision.Jan 9 2015, 7:01 PM
epriestley edited edge metadata.

Awesome!

This revision is now accepted and ready to land.Jan 9 2015, 7:01 PM
Closed by commit rP152072fc974b: OAuthServer - harden things up a bit (authored by btrahan, committed by btrahan). · Explain WhyJan 9 2015, 7:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
oauthserver/
14 lines
__tests__/
18 lines
docs/
contributor/
48 lines

Diff 27146

View Options

src/applications/oauthserver/PhabricatorOAuthServer.php

Loading...
View Options

src/applications/oauthserver/__tests__/PhabricatorOAuthServerTestCase.php

Loading...
View Options

src/docs/contributor/using_oauthserver.diviner

Loading...
Phabricator · Built by Phacility