Fix an issue with clearing cookies when a cookie prefix is set
ClosedPublic
Actions

Authored by epriestley on Jan 8 2015, 8:10 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rPcecc08756e61: Fix an issue with clearing cookies when a cookie prefix is set

Summary

If a cookie prefix is set (as on the Phacility cluster), we end up double-namespacing cookies when trying to remove them. This can make logging out produce a cookie error.

Test Plan

Logged out locally with cookie prefix, got normal logout workflow.

Diff Detail

Repository

rP Phabricator

Branch

clearcookie

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3694
Build 3704: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27111.Jan 8 2015, 8:10 PM

epriestley retitled this revision from to Fix an issue with clearing cookies when a cookie prefix is set.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 8 2015, 8:10 PM

epriestley added inline comments.Jan 8 2015, 8:16 PM

src/aphront/AphrontRequest.php
459	Specifically, the name gets prefixed here.

btrahan accepted this revision.Jan 8 2015, 11:06 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 8 2015, 11:06 PM

Closed by commit rPcecc08756e61: Fix an issue with clearing cookies when a cookie prefix is set (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2015, 12:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

1 line

Diff 27111

View Options

src/aphront/AphrontRequest.php

Fix an issue with clearing cookies when a cookie prefix is setClosedPublicActions