Differential D11258

T6555, When creating a task with a non existing parent parameter, phabricator should 404
ClosedPublic
Actions

Authored by lpriestley on Jan 6 2015, 7:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 30, 10:25 AM

	Unknown Object (File)
	Sat, Dec 28, 2:38 AM

	Unknown Object (File)
	Fri, Dec 27, 10:53 PM

	Unknown Object (File)
	Tue, Dec 24, 7:38 AM

	Unknown Object (File)
	Sat, Dec 21, 6:00 AM

	Unknown Object (File)
	Fri, Dec 20, 3:04 PM

	Unknown Object (File)
	Thu, Dec 19, 12:37 AM

	Unknown Object (File)
	Fri, Dec 13, 12:15 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6555: When creating a task with a non existing parent parameter, there is no warning the parent task doesn't exist

Commits

Restricted Diffusion Commit
rP9c568802bb77: T6555, When creating a task with a non existing parent parameter, phabricator…

Summary

Fixes T6555, The following should 404: /maniphest/task/create/?parent=asdf, /maniphest/task/create/?parent=0, /maniphest/task/create/?parent=999999 (where T999999 does not exist)

Test Plan

Navigate to /maniphest/task/create/?parent=asdf or /maniphest/task/create/?parent=0 or /maniphest/task/create/?parent=999999 (where T999999 does not exist). See 404.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 27022.Jan 6 2015, 7:47 PM

lpriestley retitled this revision from to T6555, When creating a task with a non existing parent parameter, phabricator should 404.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T6555: When creating a task with a non existing parent parameter, there is no warning the parent task doesn't exist.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 7:47 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 6 2015, 7:48 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2015, 7:48 PM

Closed by commit rP9c568802bb77: T6555, When creating a task with a non existing parent parameter, phabricator… (authored by lpriestley, committed by epriestley). · Explain WhyJan 6 2015, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskEditController.php

5 lines

Diff 27023

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...