Don't say "K&R style" in coding conventions
ClosedPublic
Actions

Authored by epriestley on Jan 6 2015, 6:40 PM.

Tags

None

Referenced Files

	F18089105: D11255.diff
	Wed, Aug 6, 10:25 AM

	F18084852: D11255.id.diff
	Tue, Aug 5, 5:57 PM

	F18082396: D11255.id27014.diff
	Tue, Aug 5, 5:48 AM

	F18078906: D11255.id27015.diff
	Mon, Aug 4, 8:31 PM

	F18056399: D11255.id27015.diff
	Mon, Aug 4, 8:23 AM

	F17853898: D11255.diff
	Jul 27 2025, 2:29 PM

	F17840910: D11255.id27014.diff
	Jul 26 2025, 9:42 PM

	F17794437: D11255.diff
	Jul 24 2025, 11:50 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
staticshock

Commits

Restricted Diffusion Commit
rPb2e71bcb7071: Don't say "K&R style" in coding conventions

Summary

We technically don't use K&R. These documents and the rest of the codebase are full of examples of the correct style, which should be unambiguous to a reasonable reader.

Test Plan

reading

Diff Detail

Repository

rP Phabricator

Branch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3639
Build 3648: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27014.Jan 6 2015, 6:40 PM

epriestley retitled this revision from to Don't say "K&R style" in coding conventions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: staticshock, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 6 2015, 6:40 PM

btrahan accepted this revision.Jan 6 2015, 6:46 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2015, 6:46 PM

Closed by commit rPb2e71bcb7071: Don't say "K&R style" in coding conventions (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2015, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

docs/

contributor/

javascript_coding_standards.diviner

1 line

php_coding_standards.diviner

1 line

Diff 27014

View Options

src/docs/contributor/javascript_coding_standards.diviner