Differential D11229

Projects - display "members" link in disabled style if user can't edit project
ClosedPublic
Actions

Authored by btrahan on Jan 5 2015, 11:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 3:05 AM

	Unknown Object (File)
	Thu, Dec 12, 8:59 PM

	Unknown Object (File)
	Wed, Dec 11, 6:32 PM

	Unknown Object (File)
	Sun, Dec 8, 12:34 PM

	Unknown Object (File)
	Sun, Dec 8, 5:28 AM

	Unknown Object (File)
	Sat, Dec 7, 8:31 AM

	Unknown Object (File)
	Fri, Dec 6, 4:21 AM

	Unknown Object (File)
	Wed, Dec 4, 1:36 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6862: Grey out 'Edit Members' link if User does not have Can Edit on project

Commits

Restricted Diffusion Commit
rPad1da6ec5ed3: Projects - display "members" link in disabled style if user can't edit project

Summary

Fixes T6862.

Test Plan

viewed a project list and saw disabled-style "Members" links as appropos

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26959.Jan 5 2015, 11:24 PM

btrahan added a task: T6862: Grey out 'Edit Members' link if User does not have Can Edit on project.

btrahan retitled this revision from to Projects - display "members" link in disabled style if user can't edit project.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: chad, epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 5 2015, 11:24 PM

btrahan added inline comments.Jan 5 2015, 11:25 PM

src/applications/project/query/PhabricatorProjectSearchEngine.php
231–242	the other thing I could do here is make "workflow" true in this case, which would make this a nice dialogue and not a full, page re-load 404 nice dialogue.

...do the conditional workflow; seems like a more-standard / better behavior.

chad accepted this revision.Jan 5 2015, 11:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 5 2015, 11:32 PM

move data loading to before the foreach loop (re-run tests and still good) this change alleviates performance concern

btrahan updated this object.Jan 5 2015, 11:39 PM

Closed by commit rPad1da6ec5ed3: Projects - display "members" link in disabled style if user can't edit project (authored by btrahan, committed by btrahan). · Explain WhyJan 5 2015, 11:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectSearchEngine.php

17 lines

Diff 26963

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...