Page MenuHomePhabricator
Differential D11229

Projects - display "members" link in disabled style if user can't edit project
ClosedPublic
Actions

Authored by btrahan on Jan 5 2015, 11:24 PM.
Tags
None
Referenced Files
F14040854: D11229.id.diff
Mon, Nov 11, 1:48 PM
F14038923: D11229.id26963.diff
Mon, Nov 11, 2:49 AM
F14038842: D11229.id26959.diff
Mon, Nov 11, 2:25 AM
F14038574: D11229.diff
Mon, Nov 11, 12:27 AM
F14036993: D11229.diff
Sun, Nov 10, 1:18 PM
F14036724: D11229.id26960.diff
Sun, Nov 10, 11:48 AM
F14036412: D11229.id.diff
Sun, Nov 10, 10:09 AM
F14036221: D11229.diff
Sun, Nov 10, 9:11 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6862: Grey out 'Edit Members' link if User does not have Can Edit on project
Commits
Restricted Diffusion Commit
rPad1da6ec5ed3: Projects - display "members" link in disabled style if user can't edit project
Summary

Fixes T6862.

Test Plan

viewed a project list and saw disabled-style "Members" links as appropos

Diff Detail

Repository
rP Phabricator
Branch
T6862
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3602
Build 3610: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26959.Jan 5 2015, 11:24 PM
btrahan added a task: T6862: Grey out 'Edit Members' link if User does not have Can Edit on project.
btrahan retitled this revision from to Projects - display "members" link in disabled style if user can't edit project.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: chad, epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 5 2015, 11:24 PM
btrahan added inline comments.Jan 5 2015, 11:25 PM
src/applications/project/query/PhabricatorProjectSearchEngine.php
231–242

the other thing I could do here is make "workflow" true in this case, which would make this a nice dialogue and not a full, page re-load 404 nice dialogue.

btrahan updated this revision to Diff 26960.Jan 5 2015, 11:29 PM

...do the conditional workflow; seems like a more-standard / better behavior.

chad accepted this revision.Jan 5 2015, 11:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2015, 11:32 PM
btrahan updated this revision to Diff 26962.Jan 5 2015, 11:39 PM
btrahan edited edge metadata.

move data loading to before the foreach loop (re-run tests and still good) this change alleviates performance concern

btrahan updated this object.Jan 5 2015, 11:39 PM
Closed by commit rPad1da6ec5ed3: Projects - display "members" link in disabled style if user can't edit project (authored by btrahan, committed by btrahan). · Explain WhyJan 5 2015, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
query/
17 lines

Diff 26962

View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
Phabricator · Built by Phacility