Differential D11128

Correct ObjectItem height when no attributes are attached
ClosedPublic
Actions

Authored by chad on Jan 1 2015, 8:38 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPe048eaf1f567: Correct ObjectItem height when no attributes are attached

Summary

If we have a byline, but no attributes, the height of the entire object is off by 4 pixels.

Test Plan

Review list of recent commits, see correct padding.

Diff Detail

Repository

rP Phabricator

Branch

obj-byline-padding

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3463
Build 3470: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26720.Jan 1 2015, 8:38 PM

chad retitled this revision from to Correct ObjectItem height when no attributes are attached.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 1 2015, 8:38 PM

epriestley accepted this revision.Jan 2 2015, 6:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 2 2015, 6:35 PM

Closed by commit rPe048eaf1f567: Correct ObjectItem height when no attributes are attached (authored by chad, committed by chad). · Explain WhyJan 2 2015, 7:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-object-item-list-view.css

2 lines

Diff 26720

View Options

resources/celerity/map.php