Page MenuHomePhabricator
Differential D11100

Don't check "repository.default-local-path" for readability in a cluster environment
ClosedPublic
Actions

Authored by epriestley on Dec 31 2014, 3:45 PM.
Tags
None
Referenced Files
F14483102: D11100.diff
Mon, Dec 30, 2:26 PM
Unknown Object (File)
Tue, Dec 24, 5:40 AM
Unknown Object (File)
Tue, Dec 24, 4:03 AM
Unknown Object (File)
Sat, Dec 21, 6:08 PM
Unknown Object (File)
Fri, Dec 20, 10:40 PM
Unknown Object (File)
Fri, Dec 13, 8:47 PM
Unknown Object (File)
Fri, Dec 13, 7:03 PM
Unknown Object (File)
Fri, Dec 13, 4:23 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2783: Make working-copy operations service-oriented
Commits
Restricted Diffusion Commit
rP376729b44c88: Don't check "repository.default-local-path" for readability in a cluster…
Summary

Ref T2783. When repository services are defined, skip the check for local repository storage.

In particular, in the Phacility cluster, this path won't exist on web nodes, but nothing will ever try to access it.

Test Plan

Verified new branch gets hit with cluster services defined.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26646.Dec 31 2014, 3:45 PM
epriestley retitled this revision from to Don't check "repository.default-local-path" for readability in a cluster environment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2783: Make working-copy operations service-oriented.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 31 2014, 3:45 PM
btrahan accepted this revision.Dec 31 2014, 7:49 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 7:49 PM
Closed by commit rP376729b44c88: Don't check "repository.default-local-path" for readability in a cluster… (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2014, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
19 lines

Diff 26653

View Options

src/applications/config/check/PhabricatorSetupCheckRepositories.php

Loading...
Phabricator · Built by Phacility