Diffusion - fix first "old ref" in push log
ClosedPublic
Actions

Authored by btrahan on Dec 30 2014, 11:07 PM.

Tags

None

Referenced Files

	F14034006: D11096.diff
	Sat, Nov 9, 9:28 PM

	F14021269: D11096.diff
	Wed, Nov 6, 6:54 AM

	F14012134: D11096.id26638.diff
	Fri, Nov 1, 7:22 AM

	F13985300: D11096.id26638.diff
	Sun, Oct 20, 7:33 PM

	F13976192: D11096.diff
	Fri, Oct 18, 1:13 PM

	F13967056: D11096.id.diff
	Wed, Oct 16, 11:19 AM

	Unknown Object (File)
	Oct 4 2024, 12:09 PM

	Unknown Object (File)
	Oct 4 2024, 11:14 AM

View All Files

Subscribers

epriestley

Korvin

Tokens

"Like" token, awarded by epriestley.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6826: Initial Push In Log shows invalid hash

Commits

Restricted Diffusion Commit
rP12c7c399ce14: Diffusion - fix first "old ref" in push log

Summary

This is a fake hash of many 0s which ends up being a bad link. Detect the fake hash and don't print a link. Fixes T6826.

Test Plan

looked at push log and no longer saw a many 0 entry for the first old ref.

Diff Detail

Repository

rP Phabricator

Branch

T6826

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3408
Build 3415: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26637.Dec 30 2014, 11:07 PM

btrahan added a task: T6826: Initial Push In Log shows invalid hash.

btrahan retitled this revision from to Diffusion - fix first "old ref" in push log.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 30 2014, 11:07 PM

chad accepted this revision.Dec 30 2014, 11:13 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 11:13 PM

Closed by commit rP12c7c399ce14: Diffusion - fix first "old ref" in push log (authored by btrahan, committed by btrahan). · Explain WhyDec 30 2014, 11:18 PM

This revision was automatically updated to reflect the committed changes.

epriestley awarded a token.Dec 30 2014, 11:34 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionPushLogListView.php

16 lines

Diff 26637

View Options

src/applications/diffusion/view/DiffusionPushLogListView.php

Diffusion - fix first "old ref" in push logClosedPublicActions