Page MenuHomePhabricator
Differential D11090

Separate daemon task table rendering into a standalone class
ClosedPublic
Actions

Authored by epriestley on Dec 30 2014, 5:57 PM.
Tags
None
Referenced Files
F15380653: D11090.diff
Fri, Mar 14, 3:59 AM
F15374294: D11090.id26620.diff
Wed, Mar 12, 6:18 PM
Unknown Object (File)
Feb 19 2025, 5:21 AM
Unknown Object (File)
Feb 8 2025, 12:32 AM
Unknown Object (File)
Feb 8 2025, 12:32 AM
Unknown Object (File)
Feb 8 2025, 12:32 AM
Unknown Object (File)
Feb 8 2025, 12:32 AM
Unknown Object (File)
Feb 7 2025, 9:43 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6238: Implement a user-facing instance management application for SAAS
T5402: Record `objectPHID` on queue tasks, as a debugging hint
Commits
Restricted Diffusion Commit
rPc2f4ae3502d8: Separate daemon task table rendering into a standalone class
Summary

Ref T5402, T6238. Pull this out into a class so the Instances app can embed task views.

Test Plan

Loaded /daemon/ and examined the content in the tables.

Diff Detail

Repository
rP Phabricator
Branch
daemons2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3395
Build 3402: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26619.Dec 30 2014, 5:57 PM
epriestley retitled this revision from to Separate daemon task table rendering into a standalone class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5402: Record `objectPHID` on queue tasks, as a debugging hint, T6238: Implement a user-facing instance management application for SAAS.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 30 2014, 5:57 PM
chad accepted this revision.Dec 30 2014, 5:59 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Dec 30 2014, 5:59 PM
epriestley added a comment.Dec 30 2014, 5:59 PM

Closed by commit rPc2f4ae3502d8: Separate daemon task table rendering into a standalone class (authored by epriestley, committed by epriestley). · Explain WhyDec 30 2014, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
daemon/
controller/
58 lines
view/
79 lines

Diff 26619

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...
View Options

src/applications/daemon/view/PhabricatorDaemonTasksTableView.php

Loading...
Phabricator · Built by Phacility