Page MenuHomePhabricator

Add IP range / CIDR utilities to libphutil
ClosedPublic

Authored by epriestley on Dec 23 2014, 11:55 PM.
Tags
None
Referenced Files
F14075464: D11043.diff
Thu, Nov 21, 11:31 AM
Unknown Object (File)
Wed, Nov 20, 3:54 PM
Unknown Object (File)
Sun, Nov 17, 1:27 PM
Unknown Object (File)
Fri, Oct 25, 5:23 AM
Unknown Object (File)
Oct 22 2024, 3:01 PM
Unknown Object (File)
Oct 22 2024, 3:48 AM
Unknown Object (File)
Oct 17 2024, 9:54 AM
Unknown Object (File)
Oct 15 2024, 11:15 AM
Subscribers

Details

Summary

Ref T6706. Ref T2783.

  • In the long run, I want to allow authentication artifacts to be restricted to specific IP ranges (for example, a bot's Conduit token might only work if the bot is on the corporate network).
  • Right now, I want to require HTTPS only for calls from outside the Phacility network. Calls between boxes get to use HTTP so we don't have to deal with the SSL for now / maybe ever.
Test Plan

Wrote a pile of test coverage.

Diff Detail

Repository
rPHU libphutil
Branch
cidr
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3330
Build 3337: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add IP range / CIDR utilities to libphutil.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 12:05 AM
This revision was automatically updated to reflect the committed changes.