suppress confusing output about branching in --nobranch mode
Needs RevisionPublic
Actions

Authored by defuzz on Dec 18 2014, 3:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 7:46 AM

	Unknown Object (File)
	Oct 21 2024, 3:58 AM

	Unknown Object (File)
	Oct 18 2024, 2:34 AM

	Unknown Object (File)
	Oct 16 2024, 12:12 PM

	Unknown Object (File)
	Sep 30 2024, 4:02 PM

	Unknown Object (File)
	Sep 24 2024, 8:12 PM

	Unknown Object (File)
	Sep 23 2024, 8:26 PM

	Unknown Object (File)
	Sep 23 2024, 9:43 AM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

If --nobranch is passed, don't let user know that a temporary branch is being created.

Test Plan

I've verified that the command still works manually.

Diff Detail

Repository

rARC Arcanist

Branch

dont_create_branch_when_nobranch_given

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3283
Build 3290: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

defuzz updated this revision to Diff 26431.Dec 18 2014, 3:26 AM

defuzz retitled this revision from to suppress confusing output about branching in --nobranch mode.

defuzz updated this object.

defuzz edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 18 2014, 3:26 AM

Herald added a subscriber: epriestley. · View Herald Transcript

rebasing to remove first attempt and it's revert

Could someone please look at this?

Thanks,
Andy

This change was created to address user confusion mentioned in https://secure.phabricator.com/T6777.

See T6777.

This revision now requires changes to proceed.Nov 23 2015, 4:03 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPatchWorkflow.php

10 lines

Diff 26431

View Options

src/workflow/ArcanistPatchWorkflow.php

suppress confusing output about branching in --nobranch modeNeeds RevisionPublicActions