Page MenuHomePhabricator

Allow Almanac services to be locked
ClosedPublic

Authored by epriestley on Dec 18 2014, 1:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:12 AM
Unknown Object (File)
Sun, Dec 15, 3:49 AM
Unknown Object (File)
Sun, Dec 15, 3:49 AM
Unknown Object (File)
Sun, Dec 15, 3:45 AM
Unknown Object (File)
Sun, Dec 15, 3:38 AM
Unknown Object (File)
Thu, Dec 12, 2:16 AM
Unknown Object (File)
Thu, Dec 5, 7:57 AM
Unknown Object (File)
Nov 24 2024, 11:02 PM
Subscribers

Details

Summary

Fixes T6741. This allows Almanac services to be locked from the CLI. Locked services (and their bindings, interfaces and devices) can not be edited. This serves two similar use cases:

  • For normal installs, you can protect cluster configuration from an attacker who compromises an account (or generally harden services which are intended to be difficult to edit).
  • For Phacility, we can lock externally-managed instance cluster configuration without having to pull any spooky tricks.
Test Plan
  • Locked and unlocked services.
  • Verified locking a service locks connected properties, bindings, binding properties, interfaces, devices, and device properties.

Diff Detail

Repository
rP Phabricator
Branch
dxstore3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3282
Build 3289: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow Almanac services to be locked.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/almanac/servicetype/AlmanacClusterServiceType.php
30–31

"See %s for more information." maybe?

This revision is now accepted and ready to land.Dec 18 2014, 9:30 PM
This revision was automatically updated to reflect the committed changes.