Differential D10973

Transactions - make quotes work for older transactions
ClosedPublic
Actions

Authored by btrahan on Dec 11 2014, 6:17 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6731: No "quote" option for some discussion comments

Commits

Restricted Diffusion Commit
rPb718b429afc6: Transactions - make quotes work for older transactions

Summary

Fixes T6731. I don't really understand the intent behind the two view classes here, but to get this to work I need to pass yet more data to the lower-level class.

Test Plan

Viewed a task with many comments. Clicked "show older". Quoted everything I could. Verified for each quote that it quoted correctly, inlcuding linking to the prior transaction.

Diff Detail

Repository

rP Phabricator

Branch

T6731

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3234
Build 3240: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26349.Dec 11 2014, 6:17 PM

btrahan added a task: T6731: No "quote" option for some discussion comments.

btrahan retitled this revision from to Transactions - make quotes work for older transactions.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 11 2014, 6:17 PM

The TimelineView is/was a mostly-pure UI class, in theory, but in practice it's pretty tightly coupled with transaction records now. I think this is fine.

You could also let extra be put on the Pager, but whatevs.

This revision is now accepted and ready to land.Dec 11 2014, 6:26 PM

Closed by commit rPb718b429afc6: Transactions - make quotes work for older transactions (authored by btrahan, committed by btrahan). · Explain WhyDec 11 2014, 6:27 PM

This revision was automatically updated to reflect the committed changes.