Page MenuHomePhabricator

Allow ConduitClient to specify an explicit Host
ClosedPublic

Authored by epriestley on Dec 10 2014, 6:21 PM.
Tags
None
Referenced Files
F14117178: D10960.id26326.diff
Thu, Nov 28, 5:39 PM
Unknown Object (File)
Wed, Nov 27, 1:55 AM
Unknown Object (File)
Tue, Nov 26, 3:09 AM
Unknown Object (File)
Oct 17 2024, 8:03 PM
Unknown Object (File)
Oct 1 2024, 9:54 PM
Unknown Object (File)
Oct 1 2024, 6:51 PM
Unknown Object (File)
Sep 22 2024, 2:35 AM
Unknown Object (File)
Sep 20 2024, 10:08 PM
Subscribers

Details

Summary

Ref T2783. To query a repository, we want to connect to a node which hosts it, but also connect using the correct instance hostname.

Allow ConduitClient to specify an explicit hostname.

Test Plan

Used a script like this to verify that setHost() is impactful:

<?php

require_once 'scripts/__init_script__.php';

$response = id(new ConduitClient('http://127.0.0.1/'))
  ->setHost('local.phacility.com')
  ->callMethodSynchronous('conduit.ping', array());

var_dump($response);

Diff Detail

Repository
rPHU libphutil
Branch
pbind1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3215
Build 3221: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow ConduitClient to specify an explicit Host.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2014, 9:29 PM
This revision was automatically updated to reflect the committed changes.