Differential D10945

When a worker task fails permanently, log the reason
ClosedPublic
Actions

Authored by epriestley on Dec 8 2014, 1:24 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6238: Implement a user-facing instance management application for SAAS

Commits

Restricted Diffusion Commit
rP139c63bd84e5: When a worker task fails permanently, log the reason

Summary

Ref T6238. This makes debugging permanent task failures easier (we log reasoning for temporary failures already, just not permanent ones).

Test Plan

Saw more useful permanent failure log.

Diff Detail

Repository

rP Phabricator

Branch

permfail

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3197
Build 3203: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26286.Dec 8 2014, 1:24 PM

epriestley retitled this revision from to When a worker task fails permanently, log the reason.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6238: Implement a user-facing instance management application for SAAS.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 8 2014, 1:24 PM

btrahan accepted this revision.Dec 8 2014, 5:14 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Dec 8 2014, 5:14 PM

Closed by commit rP139c63bd84e5: When a worker task fails permanently, log the reason (authored by epriestley, committed by epriestley). · Explain WhyDec 8 2014, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

workers/

PhabricatorTaskmasterDaemon.php

6 lines

Diff 26286

View Options

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

When a worker task fails permanently, log the reasonClosedPublicActions