we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite...
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4712: Paginate transactions on objects once there are a huge number of them
- Commits
- Restricted Diffusion Commit
rP2856c6093240: Transactions - kill the old "show all" code pathways
viewed a task with a lot of transactions. clicked "show older" and it worked!
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T4712f
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3174 Build 3180: [Placeholder Plan] Wait for 30 Seconds