Page MenuHomePhabricator

Fix an issue with tail parsing in object embeds in remarkup
ClosedPublic

Authored by epriestley on Dec 2 2014, 1:53 AM.
Tags
None
Referenced Files
F14006168: D10915.diff
Mon, Oct 28, 2:23 AM
F13969001: D10915.id26218.diff
Oct 16 2024, 11:54 PM
F13958091: D10915.id.diff
Oct 14 2024, 12:49 PM
Unknown Object (File)
Oct 5 2024, 5:13 AM
Unknown Object (File)
Oct 5 2024, 2:16 AM
Unknown Object (File)
Sep 21 2024, 1:26 AM
Unknown Object (File)
Sep 11 2024, 1:45 AM
Unknown Object (File)
Sep 3 2024, 3:34 PM
Subscribers

Details

Summary

Fixes T6619. In {Xnnn key=value, key=value} we did not require a separator between the object and the key-value part. This could lead to {rX11aaa} being parsed as {rX11 aaa}, i.e. a reference to rX11 with parameter aaa set.

Instead, require a space or comma before we'll parse key-value parts of embedded objects.

Test Plan

Added and executed unit tests.

Screen_Shot_2014-12-01_at_5.53.30_PM.png (457×545 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
rrule
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3158
Build 3164: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix an issue with tail parsing in object embeds in remarkup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2014, 1:57 AM
This revision was automatically updated to reflect the committed changes.