Page MenuHomePhabricator
Differential D10897

Clean up UITooltips
ClosedPublic
Actions

Authored by chad on Nov 24 2014, 7:55 PM.
Tags
None
Referenced Files
F14024099: D10897.diff
Thu, Nov 7, 5:51 AM
F13997164: D10897.id26181.diff
Thu, Oct 24, 2:43 AM
F13962454: D10897.diff
Tue, Oct 15, 10:09 AM
Unknown Object (File)
Sun, Oct 13, 7:49 AM
Unknown Object (File)
Sun, Oct 13, 7:47 AM
Unknown Object (File)
Oct 10 2024, 4:17 AM
Unknown Object (File)
Oct 2 2024, 9:15 AM
Unknown Object (File)
Sep 26 2024, 6:29 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP895b5580f22f: Clean up UITooltips
Summary

Fixes positioning issues by creating another container to hold the abs. positioned arrows. (Issues primarily presented on Workboards).

Test Plan

Test UI arrows on a workboard, applciation launcher, and in UIExamples.

Diff Detail

Repository
rP Phabricator
Branch
tooltip-z
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/ToolTip.js:40TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 3136
Build 3142: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26179.Nov 24 2014, 7:55 PM
chad retitled this revision from to Clean up UITooltips.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 24 2014, 7:55 PM
Harbormaster completed remote builds in B3136: Diff 26179.Nov 24 2014, 7:56 PM
epriestley accepted this revision.Nov 24 2014, 7:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2014, 7:56 PM
chad updated this revision to Diff 26180.Nov 24 2014, 7:57 PM
chad edited edge metadata.
  • lint
Closed by commit rP895b5580f22f: Clean up UITooltips (authored by chad, committed by chad). · Explain WhyNov 24 2014, 7:57 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B3137: Diff 26180.Nov 24 2014, 7:57 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
applications/
uiexample/
examples/
8 lines
webroot/
rsrc/
css/
aphront/
25 lines
js/
core/
6 lines

Diff 26179

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorUITooltipExample.php

Loading...
View Options

webroot/rsrc/css/aphront/tooltip.css

Loading...
View Options

webroot/rsrc/js/core/ToolTip.js

Loading...
Phabricator · Built by Phacility