Page MenuHomePhabricator
Differential D10890

Add default View, Edit, and Join Policies to Projects
ClosedPublic
Actions

Authored by chad on Nov 21 2014, 5:07 AM.
Tags
None
Referenced Files
F14058792: D10890.diff
Sun, Nov 17, 2:49 PM
F13995163: D10890.diff
Wed, Oct 23, 11:03 AM
F13985950: D10890.id.diff
Sun, Oct 20, 11:47 PM
F13979113: D10890.id26155.diff
Oct 19 2024, 2:45 AM
F13979112: D10890.id26160.diff
Oct 19 2024, 2:45 AM
F13975831: D10890.id26161.diff
Oct 18 2024, 11:48 AM
F13975408: D10890.id.diff
Oct 18 2024, 9:59 AM
F13975380: D10890.id.diff
Oct 18 2024, 9:53 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Orange Medal" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T6567: Add ability to set default Project Policy
Commits
Restricted Diffusion Commit
rP32b1ffdf894c: Add default View, Edit, and Join Policies to Projects
Summary

Fixes T6567, lets admins set a default policy for new Projects.

Test Plan

Changed the default Policy, created a new Project. Project had correct defaults.

Diff Detail

Repository
rP Phabricator
Branch
proj-policy
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3122
Build 3128: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26155.Nov 21 2014, 5:07 AM
chad retitled this revision from to Add default View, Edit, and Join Policies to Projects.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T6567: Add ability to set default Project Policy.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 21 2014, 5:07 AM
Harbormaster completed remote builds in B3120: Diff 26155.Nov 21 2014, 5:08 AM
btrahan awarded a token.Nov 21 2014, 6:37 AM
Harbormaster completed remote builds in B3120: Diff 26155.Nov 21 2014, 2:20 PM
epriestley accepted this revision.Nov 21 2014, 7:07 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/project/capability/ProjectDefaultEditCapability.php
13–15

You should be able to just omit this; the default is false.

This revision is now accepted and ready to land.Nov 21 2014, 7:07 PM
chad updated this revision to Diff 26160.Nov 21 2014, 7:20 PM
chad edited edge metadata.
  • Remove unneeded functions
Harbormaster completed remote builds in B3122: Diff 26160.Nov 21 2014, 7:21 PM
Closed by commit rP32b1ffdf894c: Add default View, Edit, and Join Policies to Projects (authored by chad, committed by chad). · Explain WhyNov 21 2014, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26160

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/application/PhabricatorProjectApplication.php

Loading...
View Options

src/applications/project/capability/ProjectDefaultEditCapability.php

Loading...
View Options

src/applications/project/capability/ProjectDefaultJoinCapability.php

Loading...
View Options

src/applications/project/capability/ProjectDefaultViewCapability.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
Phabricator · Built by Phacility