Page MenuHomePhabricator
Differential D10889

Add workboard link to emails about workboard changes
ClosedPublic
Actions

Authored by lpriestley on Nov 21 2014, 1:22 AM.
Tags
None
Referenced Files
F14892613: D10889.id26151.diff
Sun, Feb 9, 7:14 AM
Unknown Object (File)
Sat, Feb 8, 12:11 AM
Unknown Object (File)
Sat, Feb 8, 12:11 AM
Unknown Object (File)
Sat, Feb 8, 12:11 AM
Unknown Object (File)
Sat, Feb 8, 12:11 AM
Unknown Object (File)
Sun, Feb 2, 9:46 PM
Unknown Object (File)
Fri, Jan 31, 7:40 AM
Unknown Object (File)
Thu, Jan 23, 6:42 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by chad.

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4652: Put a workboard link in the email Maniphest sends out about workboard changes
Commits
Restricted Diffusion Commit
rPc2f0955e9bd2: Add workboard link to emails about workboard changes
Summary

Fixes T4652, adding workboard link to emails

Test Plan

Move a task in a workboard from one column to another. Email notification should contain "WORKBOARD" section with link to that workboard

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 26150.Nov 21 2014, 1:22 AM
lpriestley retitled this revision from to Add workboard link to emails about workboard changes.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T4652: Put a workboard link in the email Maniphest sends out about workboard changes.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 21 2014, 1:22 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B3117: Diff 26150.Nov 21 2014, 1:23 AM
epriestley accepted this revision.Nov 21 2014, 1:24 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2014, 1:24 AM
epriestley added inline comments.Nov 21 2014, 1:26 AM
src/applications/maniphest/editor/ManiphestTransactionEditor.php
527

Oh, this link should just be /project/, not /projects/. I'll tweak that in the pull.

Closed by commit rPc2f0955e9bd2: Add workboard link to emails about workboard changes (authored by lpriestley, committed by epriestley). · Explain WhyNov 21 2014, 1:27 AM
This revision was automatically updated to reflect the committed changes.
chad awarded a token.Nov 21 2014, 1:29 AM

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
maniphest/
editor/
28 lines

Diff 26151

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
Phabricator · Built by Phacility