Page MenuHomePhabricator
Differential D10817

Owners / Audit - restore link to view audits related to an owners package.
ClosedPublic
Actions

Authored by btrahan on Nov 8 2014, 12:34 AM.
Tags
None
Referenced Files
F14087565: D10817.diff
Sat, Nov 23, 10:38 PM
Unknown Object (File)
Tue, Nov 19, 3:15 PM
Unknown Object (File)
Mon, Nov 11, 7:33 AM
Unknown Object (File)
Sat, Nov 9, 8:42 AM
Unknown Object (File)
Sat, Nov 9, 8:42 AM
Unknown Object (File)
Sat, Nov 9, 8:42 AM
Unknown Object (File)
Sat, Nov 9, 5:15 AM
Unknown Object (File)
Tue, Nov 5, 9:29 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5387: "Related commits" for packages in Owners application is broken
Commits
Restricted Diffusion Commit
rP796428c810a0: Owners / Audit - restore link to view audits related to an owners package.
Summary

Fixes T5387. I broke this in D8805. Fix it by using the application search parameters that D8805 introduced.

Test Plan

verified that the two links mentioned in T5387 worked for me. Also tried manual links on secure.phabricator.com and those showed the right data even...!

Diff Detail

Repository
rP Phabricator
Branch
T5387
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2995
Build 2999: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25964.Nov 8 2014, 12:34 AM
btrahan added a task: T5387: "Related commits" for packages in Owners application is broken.
btrahan retitled this revision from to Owners / Audit - restore link to view audits related to an owners package..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 8 2014, 12:34 AM
Harbormaster completed remote builds in B2995: Diff 25964.Nov 8 2014, 12:35 AM
epriestley accepted this revision.Nov 8 2014, 12:40 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2014, 12:40 AM
Closed by commit rP796428c810a0: Owners / Audit - restore link to view audits related to an owners package. (authored by btrahan, committed by btrahan). · Explain WhyNov 8 2014, 12:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
controller/
4 lines
2 lines

Diff 25964

View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersListController.php

Loading...
Phabricator · Built by Phacility