Page MenuHomePhabricator

Standardize SSH key storage
ClosedPublic

Authored by epriestley on Nov 7 2014, 1:12 PM.
Tags
None
Referenced Files
F14016325: D10805.diff
Mon, Nov 4, 7:54 AM
F14003017: D10805.id.diff
Sat, Oct 26, 1:09 AM
F13996657: D10805.diff
Wed, Oct 23, 10:56 PM
F13964532: D10805.id25930.diff
Oct 15 2024, 8:58 PM
Unknown Object (File)
Oct 6 2024, 3:17 PM
Unknown Object (File)
Oct 2 2024, 3:59 AM
Unknown Object (File)
Sep 27 2024, 11:49 PM
Unknown Object (File)
Sep 23 2024, 4:42 PM
Subscribers
Tokens
"Doubloon" token, awarded by btrahan.

Details

Summary

Ref T5833. This fixes a few weird things with this table:

  • A bunch of columns were nullable for no reason.
  • We stored an MD5 hash of the key (unusual) but never used it and callers were responsible for manually populating it.
  • We didn't perform known-key-text lookups by using an index.
Test Plan
  • Ran migrations.
  • Faked duplicate keys, saw them clean up correctly.
  • Added new keys.
  • Generated new keys.
  • Used bin/auth-ssh and bin/auth-ssh-key.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Standardize SSH key storage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 5:01 PM
This revision was automatically updated to reflect the committed changes.