Page MenuHomePhabricator

Assume utf8mb4 support
ClosedPublic

Authored by epriestley on Nov 6 2014, 9:09 PM.
Tags
None
Referenced Files
F15387891: D10798.id25917.diff
Sat, Mar 15, 3:04 AM
F15375412: D10798.id25917.diff
Wed, Mar 12, 11:07 PM
F15342949: D10798.id25951.diff
Sun, Mar 9, 9:41 PM
F15342948: D10798.id.diff
Sun, Mar 9, 9:41 PM
Unknown Object (File)
Wed, Feb 26, 6:10 PM
Unknown Object (File)
Mon, Feb 24, 1:03 PM
Unknown Object (File)
Sun, Feb 23, 9:36 PM
Unknown Object (File)
Feb 8 2025, 12:00 AM
Subscribers

Details

Summary

Ref T1191. This stops throwing an exception for non-BMP data when constructing queries.

  • For installs which have already adjusted, this allows emoji and other 4-byte characters to work.
  • For installs which have not adjusted yet but do have STRICT_ALL_TABLES set, MySQL will raise an error intead ("Incorrect string value...").
  • For installs which have not adjusted and also do not use STRICT_ALL_TABLES, this will silently truncate data. This is potentially a security risk. However, these installs are warned about the risk of leaving STRICT_ALL_TABLES disabled, there's no known way to exploit this issue, and they'll be auto-adjusted soon.
Test Plan

Ran locally and on secure.phabricator.com with this patch for a long time.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable